Problem/Motivation

Drupal\Core\Language\LanguageManager->getLanguage()() (Line: 157) is causing deprecations in PHP 8.5.

Steps to reproduce

Run \Drupal\Tests\menu_link_content\Functional\MenuLinkContentTranslationUITest

Proposed resolution

Fix \Drupal\content_translation\Access\ContentTranslationManageAccessCheck::access() to not call \Drupal\Core\Language\LanguageManagerInterface::getLanguage() with a null.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557522

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !13815

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Ran locally with 8.5.0RC3

Actually got failures
Exception: Deprecated function: Using null as an array offset is deprecated, use an empty string instead
Drupal\Core\Language\LanguageManager->getLanguage()() (Line: 157)

With the MR it passes with 0 deprecations

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Not a huge fan of the if followed directly by the null coalesce, but anything else is probably going to be more verbose.

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13815

  • catch committed 26d90df6 on 11.3.x 
    fix: #3557522 Fix PHP 8.5 deprecations in Drupal\Core\Language\...

  • catch committed 52e6e9f5 on 11.x 
    fix: #3557522 Fix PHP 8.5 deprecations in Drupal\Core\Language\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.