Problem/Motivation

\Drupal\Core\Entity\EntityTypeBundleInfo::getBundleInfo() has a parameter typehint in docs of string but things call it with NULL. Which triggers deprecations in PHP 8.5

Steps to reproduce

Run \Drupal\Tests\views\Kernel\Wizard\WizardPluginBaseKernelTest on PHP 8.5

Proposed resolution

Deprecate calling with NULL and fix callers.

Remaining tasks

User interface changes

None

Introduced terminology

None

API changes

New deprecation

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557135

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !13757

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented

This one of those instances there should be a commented out typehint to be uncommented in 12

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

#4 great idea. done.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Awesome! Rest LGTM.

  • catch committed 05460f77 on 11.3.x 
    fix: #3557135 Calling \Drupal\Core\Entity\EntityTypeBundleInfo::...

  • catch committed 8443c9a5 on 11.x 
    fix: #3557135 Calling \Drupal\Core\Entity\EntityTypeBundleInfo::...

catch closed merge request !13757

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

quietone commented

Reworded the change record and published.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.