According to the checkboxes documentation the options array should be in the format of [return_value] = choice, but the expand check boxes was not properly setting the return_value option. Patch is attached to correct this.

CommentFileSizeAuthor
#7 checkboxes_reroll_0.patch866 bytesSteve Dondley
#5 checkboxes_reroll.patch824 bytesSteve Dondley
checkboxes_2.patch815 bytesccourtne

Comments

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Version: » x.y.z

Could this one get reviewed by some Forms API peeps? I have a sneaking suspicion that a bug in the implementation of checkboxes is causing all manner of problems and bugs in many different parts of Drupal... most notably, theme settings.

(I would have a look myself, but I'm afraid I'm quite pissed.)

eaton’s picture

eaton commented

I've been experiencing some problems with a patch to menu.module that might be related to this as well -- if a return value and a default value are specified for a checkbox, it seems to ALWAYS return the default value even if the checkbox is unchecked. Odd stuff.

Steve Dondley’s picture

Steve Dondley commented

checkboxes code has been give a throrough overhaul by chx. this bug is dead.

eaton’s picture

eaton commented
Status: Needs review » Fixed

Agreed.

Steve Dondley’s picture

Steve Dondley commented
StatusFileSize
new checkboxes_reroll.patch824 bytes

Oops, not really. Just talked to chx in IRC. He said to reroll. Here it is.

Steve Dondley’s picture

Steve Dondley commented
Status: Fixed » Needs review
Steve Dondley’s picture

Steve Dondley commented
StatusFileSize
new checkboxes_reroll_0.patch866 bytes

same patch with the -p option applied during the diff per chx's recommendation.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to HEAD. Thanks.

ccourtne’s picture

ccourtne commented
Status: Fixed » Closed (fixed)