Problem/Motivation

Follow up to #3535662: [meta] Convert test metadata from annotations to attributes, remove remaining references to @dataProvider annotations from tests and comments.

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3556583

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !13716

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
astonvictor’s picture

astonvictor commented
Title: Remove remaining references to @dataProvider annotations from tests » Remove remaining references to @dataProvider annotations from TimestampFormatterWithTimeDiffTest test
astonvictor’s picture

astonvictor commented

Seems like two comments to the same function were added by mistake in the #2705037: Asset library DX: Non-helpful fatal error if CSS isn't nested under an existing category issue

astonvictor’s picture

astonvictor commented
Status: Needs review » Reviewed & tested by the community

Since it only requires removing the useless comment, I'll move it to RTBC.

quietone’s picture

quietone commented
Title: Remove remaining references to @dataProvider annotations from TimestampFormatterWithTimeDiffTest test » Remove remaining references to @dataProvider annotations from tests

There are two files being changed, so updating title.

  • quietone committed 6688407e on 11.3.x 
    Issue #3556583 by mondrake, astonvictor: Remove remaining references to...

  • quietone committed 17d83a56 on 11.x 
    Issue #3556583 by mondrake, astonvictor: Remove remaining references to...
quietone’s picture

quietone commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 11.x and cherry-picked to 11.3.x

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone closed merge request !13716

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.