Problem/Motivation

#1685492: Convert theme engines into services needs a quick fix because a service locator does not support $this->themeEngines->get($name, SymfonyContainerInterface::NULL_ON_INVALID_REFERENCE);

Steps to reproduce

See #3556101: [11.3.x] Semi-coupled engine not compatible with Drupal 11.x

Proposed resolution

Use has()

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3556130

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !13684

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

Will work out how to test...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

The test only job fails both the expected test cases - see https://git.drupalcode.org/issue/drupal-3556130/-/jobs/7158762

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Changes make sense, phpstan should have caught that but didn't with our configuration (\Psr\Container\ContainerInterface::get() does not have that argument either).

Failing tests are just the usual and frequent random fails, theme switch and media library.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed a30c38e4213 to 11.x and c50910413f0 to 11.3.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed c5091041 on 11.3.x 
    Issue #3556130 by alexpott: ThemeEngine BC layer is broken -...

  • longwave committed a30c38e4 on 11.x 
    Issue #3556130 by alexpott: ThemeEngine BC layer is broken -...

longwave closed merge request !13684

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.