Problem/Motivation

On PHP 8.5 the \Drupal\language\Plugin\LanguageNegotiation\LanguageNegotiationContentEntity::getLangcode() method results in deprecations when $request->query->get(static::QUERY_PARAMETER); return NULL - i.e. the query parameter is not set.

Steps to reproduce

Run the unit tests on PHP 8.5 - \Drupal\Tests\language\Unit\Plugin\LanguageNegotiation\LanguageNegotiationContentEntityTest with produce a deprecation.

Proposed resolution

Fix code to not produce a deprecation.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3555823

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
alexpott’s picture

Issue tags: +PHP 8.5
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Seems pretty straight forward.

  • catch committed d6a37195 on 11.3.x
    Issue #3555823 by alexpott: LanguageNegotiationContentEntity::...

  • catch committed f2f7a74d on 11.x
    Issue #3555823 by alexpott: LanguageNegotiationContentEntity::...

catch’s picture

Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.