Problem/Motivation

You can't rerun the cspell job because if the cache exists it fails.

Steps to reproduce

Try to rerun a successful spell checking job from the pipeline. It will fail.

Proposed resolution

Wipe node_modules before moving back (just in case files have been removed)

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3554130

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !13560

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

This critical because this pipeline can fail even if there are no cspell errors due to this and once it starts failing in a pipeline it'll never pass. Hotel California!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

https://git.drupalcode.org/issue/drupal-3035288/-/jobs/7013308 is an example where we can't get cspell to pass.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: It is impossible to rerun cspell job » If cache exists cspell job fails
Issue summary: View changes
acbramley’s picture

acbramley commented
Status: Needs review » Reviewed & tested by the community

After chatting in slack this makes sense.

nicxvan’s picture

nicxvan commented

Looks good to me, I think we might want to keep this open for investigation on what happened.

  • alexpott committed 0187048f on 11.2.x 
    Issue #3554130 by alexpott: If cache exists cspell job fails

(cherry...

  • alexpott committed 596a88e1 on 11.x 
    Issue #3554130 by alexpott: If cache exists cspell job fails
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 11.2.x-dev
Status: Reviewed & tested by the community » Fixed

Something changed in gitlab and the cache started to work. I think marking this one as fixed is fine.

I checked and 11.1.x and 10.x are not affected.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

alexpott opened merge request !13692

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Fixed » Reviewed & tested by the community

Turns out 11.1.x was affected... pushed a MR to fix it as cherry-picking didn't work.

  • alexpott committed bfa1bf15 on 11.1.x 
    Issue #3554130 by alexpott: If cache exists cspell job fails
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

The DA enabled GitLab caching a few days ago in #3387117: Enable distributed caching in GitLab Runner, we should revisit the custom cache stuff we built to see if we can improve it with the official system now.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Related issues: +#3387117: Enable distributed caching in GitLab Runner
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

#3387117: Enable distributed caching in GitLab Runner is why this broke :D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.