Problem/Motivation

I noticed the following in .gitlab-ci.yml

      changes:
        - "**/config/schema/*.schema.yml"
        # Modules may alter config schema using hook_config_schema_info_alter().
        - "**/*.module"

However, hook_config_schema_info_alter() implementations have increasingly moved to object-oriented (OOP) hooks using PHP classes under src/Hook/.

But hook_config_schema_info_alter implementations have moved to OOP hooks in php files

Steps to reproduce

Proposed resolution

Update the CI rule to also track changes to PHP files in the src/Hook/ directory:

  changes:
        - "**/config/schema/*.schema.yml"
        # Modules may alter config schema using hook_config_schema_info_alter().
        - "**/*.module"
        - "**/src/Hook/*.php"

Remaining tasks

User interface changes

NA

Introduced terminology

NA

API changes

NA

Data model changes

NA

Release notes snippet

Issue fork drupal-3529706

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mstrelan created an issue. See original summary.

annmarysruthy made their first commit to this issue’s fork.

annmarysruthy’s picture

Assigned: Unassigned » annmarysruthy

annmarysruthy’s picture

Assigned: annmarysruthy » Unassigned
Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Even if straight forward issue summary should still be complete.

annmarysruthy’s picture

Issue summary: View changes
annmarysruthy’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs issue summary update
alexpott’s picture

Version: 11.x-dev » 11.2.x-dev
Status: Reviewed & tested by the community » Fixed

Backported to 11.2.x as a test-only change.

Committed and pushed ec4fdb42579 to 11.x and 248f84d59ab to 11.2.x. Thanks!

alexpott’s picture

  • alexpott committed 248f84d5 on 11.2.x
    Issue #3529706 by annmarysruthy, smustgrave, mstrelan: Validatable...

  • alexpott committed ec4fdb42 on 11.x
    Issue #3529706 by annmarysruthy, smustgrave, mstrelan: Validatable...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.