Problem/Motivation

Found a bug introduced by #3497431: Deprecate TestDiscovery test file scanning, use PHPUnit API instead: PHPUnit's test discovery uses diffs between declared classes to identify if a test class is present in the scanned file.

This works as long as the file is loaded to PHP for the first time.

Apparently in some cases the legacy TestDiscovery, whose results the tests compare to PHPUnit's, load the classes too, before PHPUnit that in this case complains about a supposedly missing test class in the file.

Proposed resolution

Just swap the sequence of discovery in the tests - run first PHPUnit's then legacy TestDiscovery before comparing, instead of the other way round as in HEAD right now.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3526499

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mondrake created an issue. See original summary.

mondrake’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Seems pretty straight forward.

mondrake’s picture

Assigned: Unassigned » mondrake
Status: Reviewed & tested by the community » Needs work

one more failure, on it

mondrake’s picture

Assigned: mondrake » Unassigned
Status: Needs work » Needs review
mondrake’s picture

Status: Needs review » Closed (duplicate)

Will be solved in the re-opened parent.