Problem/Motivation
Found a bug introduced by #3497431: Deprecate TestDiscovery test file scanning, use PHPUnit API instead: PHPUnit's test discovery uses diffs between declared classes to identify if a test class is present in the scanned file.
This works as long as the file is loaded to PHP for the first time.
Apparently in some cases the legacy TestDiscovery, whose results the tests compare to PHPUnit's, load the classes too, before PHPUnit that in this case complains about a supposedly missing test class in the file.
Proposed resolution
Just swap the sequence of discovery in the tests - run first PHPUnit's then legacy TestDiscovery before comparing, instead of the other way round as in HEAD right now.
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3526499
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
mondrakeComment #4
smustgrave commentedSeems pretty straight forward.
Comment #5
mondrakeone more failure, on it
Comment #6
mondrakeComment #7
mondrakeComment #8
mondrakeWith this in, #3446693: Convert test annotations to attributes in Drupal/Test/Component and #3526490: Convert test annotations to attributes in Drupal/BuildTests will be passing.
Comment #9
mondrakeWill be solved in the re-opened parent.