Currently it's really hard to place fixed elements at the top of the page because Navigation's Top Bar doesn't use Drupal.displace().

We should fix this.

Issue fork drupal-3526266

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mherchel created an issue. See original summary.

mherchel changed the visibility of the branch 3526266-navigation-top-bar to hidden.

mherchel’s picture

Version: 11.0.x-dev » 11.x-dev

mherchel’s picture

StatusFileSize
new393.55 KB

Ready for review! Screenshot attached :D

mherchel’s picture

Status: Active » Needs review
solideogloria’s picture

Title: Navigation top bar should utilize Drupal.dispace() » Navigation top bar should utilize Drupal.displace()

Fixed typo

andy-blum’s picture

Status: Needs review » Reviewed & tested by the community
finnsky’s picture

Status: Reviewed & tested by the community » Needs work

Thank you, but seems not a quick fix here.

1. Position of submenu without top bar

Image from Gyazo

2. Also with top bar submenu should be aligned with top of page imo

Image from Gyazo

To fix them we need probably more delicate way to detect when top bar is empty.

finnsky’s picture

StatusFileSize
new951.78 KB
new937.43 KB
mherchel’s picture

Status: Needs work » Needs review

Good catch!

The issue was that the top bar was rendering, even if it didn't have content, which pushed down the popover.

I added a check for content within the twig file. Should be good to go. Thank you!

bernardm28’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new153.68 KB

I tested this on the tugboat link and a clean throwaway Drupal 11 site.
The top toolbar displays properly after this fix and no longer remains unrendered.
top toolbar

nod_’s picture

Version: 11.x-dev » 11.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 6bdfd060b13 to 11.x and f6ae1909c44 to 11.2.x. Thanks!

  • nod_ committed f6ae1909 on 11.2.x
    Issue #3526266 by mherchel, finnsky, andy-blum: Navigation top bar...

  • nod_ committed 6bdfd060 on 11.x
    Issue #3526266 by mherchel, finnsky, andy-blum: Navigation top bar...
nod_’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.