Problem/Motivation

Add constraint for ResponseStatus Condition status code so can be FullValidatable

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3525392

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Title: Add constraint for ResponseStatus Condition status code so can be FullValidatable » Add constraint for ResponseStatus Condition status code so it can be FullyValidatable
Issue tags: +Configuration schema, +validation
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue tags: +Novice, +Experience Builder, +Contributed project soft blocker
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Component: system.module » configuration system
irafah’s picture

irafah commented
Assigned: Unassigned » irafah

I will look at this issue.

irafah opened merge request !12647

irafah’s picture

irafah commented

I raised a merge request for this issue. The description doesn't have many details, so I just created a validation to make it fully validated, but let me know if anything else is needed.

The "Lint" tests passed, but there's a "DEFAULT: PHP 8.3 MySQL 8.0" test that failed. It seems to be related to something else, so please advise on how to proceed.

Thank you!

irafah’s picture

irafah commented
Assigned: irafah » Unassigned
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Seems like something we will need test coverage for.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

This needs defining constraints in the config schema as explicit in the issue summary + tags, not any change to form validation.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
Issue tags: +Vienna2025

Triaging this I think this still a good issue for novices. For example you can look at following issue for inspiration
#3541535: Make the `field_config_base` structure fully validatable by adding a StringEqualsConcatenatedValuesConstraint

As @penyaskito mentioned is not about form validation but adding constraints. Feel free to open a new branch

The Drupal Contribution Mentoring team is triaging issues for Drupalcon Vienna 2025, and we are reserving this issue for Mentored Contribution during the event.

After October 17th, this issue returns to being open to all. Thanks!

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.