I noticed that the Chameleon theme (and by extension the Marvin theme) do not show user signatures on comments. This patch should fix it.

CommentFileSizeAuthor
#2 chameleon_signature-d6.patch970 bytesDavid_Rothstein
chameleon_signature.patch987 bytesDavid_Rothstein

Comments

dries’s picture

dries commented
Version: 7.x-dev » 6.x-dev

Committed to CVS HEAD. Should be backported to Drupal 6? (Was $comment->signature properly escaped?)

David_Rothstein’s picture

David_Rothstein commented
StatusFileSize
new chameleon_signature-d6.patch970 bytes

Good question... I checked and tested this out, and it seems that $comment->signature is always safe to use in a theme (since it is escaped in http://api.drupal.org/api/function/user_comment/6).

The patch for D6 is attached.

David_Rothstein’s picture

David_Rothstein commented

Note that I found a closely related issue here: #351649: Chameleon and Marvin themes do not correctly use comment status

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Closed (won't fix)

I'm going to say this is a won't fix for D6, since D6 commits focus on security fixes at this point.

Anonymous’s picture

Anonymous (not verified) commented
Version: 6.x-dev » 7.x-dev
Status: Closed (won't fix) » Fixed

Changing issue status to reflect that it was fixed in 7.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.