Problem/Motivation

Part of the work to enable DrupalPractice.Objects.GlobalFunction

Steps to reproduce

Proposed resolution

Enable sniff for modules, but not tests or Hooks.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3497408

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !10805

quietone’s picture

quietone commented
Title: Fix DrupalPractice.Objects.GlobalFunction in module » Fix DrupalPractice.Objects.GlobalFunction in modules
Status: Postponed » Needs review

Time for a review.

quietone’s picture

quietone commented
Status: Needs review » Needs work

That is a mistake. There are failing tests.

quietone’s picture

quietone commented
Status: Needs work » Needs review

Now it is ready.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems pretty straightforward, rule enabled shows everything was caught. Not sure how else to test.

nod_ made their first commit to this issue’s fork.

  • nod_ committed 5509149c on 11.x 
    Issue #3497408 by quietone: Fix DrupalPractice.Objects.GlobalFunction in...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Fixed

Committed 5509149 and pushed to 11.x. Thanks!

nod_ closed merge request !10805

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.