Problem/Motivation

Drupal/Tests/Core/Render/RendererTest has a few PHPStan failures like

$ignoreErrors[] = [
	'message' => '#^Static call to instance method PHPUnit\\\\Framework\\\\TestCase\\:\\:exactly\\(\\)\\.$#',
	'identifier' => 'method.staticCall',
	'count' => 3,
	'path' => __DIR__ . '/tests/Drupal/Tests/Core/Render/RendererTest.php',
];

that are reported when PHPStan runs with PHPUnit 11 in place.

Proposed resolution

Fix.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3497128

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mondrake created an issue. See original summary.

mondrake’s picture

Status: Active » Needs review
mondrake’s picture

mondrake’s picture

Status: Needs review » Needs work

Agh, mocks in data providers...

mondrake’s picture

Status: Needs work » Needs review
longwave’s picture

Status: Needs review » Reviewed & tested by the community

The more we have to mess with these closures the more I feel like we should just refactor the entire test to be easier to read, but this will do for now.

  • catch committed 29a38829 on 11.x
    Issue #3497128 by mondrake, longwave: Fix static call to instance...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

mondrake’s picture

.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.