Problem/Motivation
Update minor and patch releases of JavaScript dependencies for 11.1.0
- Major bump/impactfull releases are handled in separate (child) issues.
- jquery a has its own issue already for getting to a stable release: #3449874: Update to jQuery 4.0.0
- eslintv9 update lives here: #3440225: Update to ESLint v9 with standard rules
The MR in this issue is a massive "One-MR-To-Update-Them-All" and is bound to fail, but at least it's a starting point to make child issues and as those are committed we get a better picture of what's needed for the rest of them.
The splitting into man(?) child issue also makes backporting of those issue easier and bumps my d.o. credits.
The downside being that if one issue lands, we probably need to rebase all the others, depending on how wel GitLab handles changes in core/yarn.lock, but I think that's extra work we have to take on the chin for the "greater good" in the end.
That greater good being the sibling-issue for 10.4.0-RC1 being either very small or ideally, non-existing after all the backports have landed.
Steps to reproduce
$ yarn upgrade-interactive
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3487576
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3487576-update-javascript-dependencies
changes, plain diff MR !10192
Comments
Comment #2
spokjeComment #3
spokjeComment #4
spokjeComment #5
spokjeComment #7
spokjeComment #8
spokjeComment #9
longwaveThanks for posting this and working on the child issues. Bumping to critical as we really should get this done for rc1.
Comment #10
spokjeComment #11
rkollerI've opened #3485202: Change the element wrapping the title in dialogs from span to heading element right after the release of jquery ui 1.14.1. @benjifisher recommended today i should be looking for a "Update JavaScript dependencies" issue, which lead me here. just wanted to note that the issue i've linked is not only about updating jquery ui to the latest version, but jquery ui introduced a setting that enables choosing into which element the dialog modal title should be wrapped. pre 1.14.1 that was a
spanwhich is semantically wrong and an accessibility issue. my question is how to proceed? should i rescope the issue i've created and make it only about the addition of that option tocore/misc/dialog/dialog.jquery-uibut then it wouldnt make it into 11.1 i suppose? for 11.0 there was a similar case where jquery ui 1.14.0 added the option for adding thearia-modalattribute to dialog modals. that option was added on the issue upgrading to 1.14.0 directly. so just wanted to post here as a headsup. in regards for changing the wrapping element of the title from a span to an h1 @mgifford already commented on #3485202: Change the element wrapping the title in dialogs from span to heading element and is also in the loop of that change.Comment #12
benjifisherThe first line of the issue summary ends with 11.0.0. I am updating it to 11.1.0, to match the title.
Comment #13
quietone commentedRC! has been released, so changing title
Comment #15
spokjeComment #16
quietone commentedChanging to fixed here because this was useful for coordinating the work on this topics and in the child issues.