Problem/Motivation

Some params in MessengerInterface are marked as optional in documentation but have no default value in the function signature.

Proposed resolution

Remove "(optional)" in these cases.

Remaining tasks

Implement.

User interface changes

None.

Introduced terminology

None.

API changes

None.

Data model changes

None.

Release notes snippet

Issue fork drupal-3487014

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

liam morland opened merge request !10156

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Seems pretty straight forward and looks like all $message have been updated.

quietone’s picture

quietone commented

This was added in #2278383: Create an injectible service for drupal_set_message() where the (optional) was valid for drupal_set_message. Should this be restoring the default value instead? I have asked in committer slack about this.

nod_ made their first commit to this issue’s fork.

longwave closed merge request !10156

  • longwave committed 957c16fc on 10.4.x 
    Issue #3487014 by liam morland, nod_, smustgrave, quietone: Fix...

  • longwave committed 46cf264b on 10.5.x 
    Issue #3487014 by liam morland, nod_, smustgrave, quietone: Fix...

  • longwave committed 8877da3b on 11.1.x 
    Issue #3487014 by liam morland, nod_, smustgrave, quietone: Fix...

  • longwave committed 4899db93 on 11.x 
    Issue #3487014 by liam morland, nod_, smustgrave, quietone: Fix...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 10.4.x-dev
Status: Reviewed & tested by the community » Fixed

This is valid, the message is no longer optional. drupal_set_message() with no arguments returned the static set of messages, now that is handled by a separate method in the messenger service.

Backported down to 10.4.x as an eligible documentation fix.

Committed and pushed 4899db93d99 to 11.x and 8877da3b01b to 11.1.x and 46cf264bf32 to 10.5.x and 957c16fc138 to 10.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.