Problem/Motivation

SF v7.2.0-BETA1 is out (https://github.com/symfony/symfony/releases/tag/v7.2.0-BETA1)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3483978

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

spokje created an issue. See original summary.

spokje’s picture

Let's see what breaks.

spokje’s picture

Assigned: Unassigned » spokje
Status: Active » Needs work

Ok, so it seems to all boil down to https://github.com/symfony/symfony/pull/57805 where (as in PHP 8.4) both the session.sid_length and session.sid_bits_per_character config options are deprecated for removal /ignoring in SF8.0.

Remove all references to both, as I did in MR!9967 makes TestBot happy again.

Let's see if I can properly deprecate those settings in the next commit(s).

longwave’s picture

Priority: Normal » Critical

Thanks for opening and working on this. If possible we should land this in 11.1.0-alpha1 this week.

longwave’s picture

Title: Symfony 7.2 » Update to Symfony 7.2.0-BETA1
spokje’s picture

Status: Needs work » Needs review

@longwave Ah, wasn't aware we're already so close to the 11.1 alpha.

Anyway: Besides the two deprecations mentioned in #4 we should be fine.

I _was_ going to ask what status this issue should have, I was guessing postponed on the actual release of SF7.2.0, but seeing this might/should/could/will/must land in 11.1 alpha, I'll put this on NR.

longwave’s picture

Status: Needs review » Needs work

The Settings deprecations are for things that go in the global $settings usually defined in settings.php; these are container parameters but not sure we have a way to deprecate those...

longwave’s picture

@catch already opened #3471199: Remove sid_length and sid_bits_per_character deprecation from CoreServiceProvider following the PHP 8.4 deprecation although nothing stopping us solving that here.

spokje’s picture

Priority: Critical » Normal

@catch already opened #3471199: Remove sid_length and sid_bits_per_character from default.services.yml following the PHP 8.4 deprecation although nothing stopping us solving that here.

Ah, i thought the removal was such an unique issue, I never even tried to search for it.

The Settings deprecations are for things that go in the global $settings usually defined in settings.php; these are container parameters but not sure we have a way to deprecate those...

Do we need something like \Drupal\Core\DependencyInjection\Compiler\DeprecatedServicePass, but for deprecated parameters?
(And yes, I'm blissfully unaware of most Containter-related magic)

spokje’s picture

Assigned: spokje » Unassigned

Reversed the incorrect deprecation attempt.

andypost’s picture

Issue tags: +Symfony 7.2
andypost’s picture

spokje’s picture

Change record should mention upgrade to SF 7.2

Not sure why this isn't sufficient?

They will be deprecated in PHP 8.4 (https://wiki.php.net/rfc/deprecations_php_8_4) and Symfony 7.2 (https://github.com/symfony/symfony/pull/57805)

https://www.drupal.org/node/3484048

longwave’s picture

Re the deprecation, maybe for this time we should just trigger directly from CoreServiceProvider::register() if $container->hasParameter(...). We can refactor to make it more dynamic or reusable later, if we have to deprecate something else.

andypost’s picture

@spokje I mean there's already published CR which could use update but #3484048 should said that core went to SF 7.2

spokje’s picture

Re the deprecation, maybe for this time we should just trigger directly from CoreServiceProvider::register() if $container->hasParameter(...). We can refactor to make it more dynamic or reusable later, if we have to deprecate something else.

Thanks @longwave

Makes sense, but:

1. It seems the SF-deprecation takes precedence, will try later with that one suppressed.
2. I think this needs a test? If so, where the *BLEEP* should I put it?

spokje’s picture

@spokje I mean there's already published CR which could use update but #3484048 should said that core went to SF 7.2

Thanks for clearing that up @andypost, I completely misunderstood that one.
And that is a _mighty_ well written CR.

The only "problem" I have with it that it is for both 10.4.0 and 11.1.0, where SF7.2 only applies to 11.1.0.
I'm sure there's a very nice way to put that into the CR, but as a non native English speaker, I don't dare to touch it, it's to nice for me to break it.

Added https://www.drupal.org/project/drupal/issues/3483978 as the CR for this issue and tagged this issue for a CR update

spokje’s picture

Status: Needs work » Needs review

Ok, so at the very least now our own deprecation warnings show up, instead of the standard SF ones.

This now needs:

- A review
- Tests?
- A rewrite of the already published CR where we mention SF7.2, but only for 11.1.0

spokje’s picture

Priority: Normal » Critical

A left-open browser window made me change the priority in #10, restoring original status

longwave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs change record updates +11.1.0 release notes

Not sure this needs a specific change record, I looked back and I don't find that we wrote change records for previous dependency updates in most cases - this is more of a release notes thing, so tagging for that instead. The change record for the session configuration options looks great to me already, I don't think we need to make any additional notes.

  • catch committed e39157a2 on 11.x
    Issue #3483978 by spokje, longwave, andypost: Update to Symfony 7.2.0-...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.