[meeting] Migrate Meeting 2024-10-24 1400Z [#3480038]

Core migration issues

Next video meeting 2025-01-02 (tentative)

Hello all, it’s time for the biweekly migration subsystem meeting. The meeting will take place in slack in various threads. This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every second Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. #3456078: [meeting] Migrate Meeting 2024-07-18 2100Z)See the parent issue for an idea of the typical agenda.
➤Transcript will be exported and posted to the agenda issue. For anonymous comments, start with a 👤 emoji. To take a comment or thread off the record, start with a 🚫 emoji.

0️⃣ Who is here today?

benjifisher	Hi! I am one of the maintainers of the Migrate API.
Dan Davis	Present
mikelutz (he/him)	Hi all
quietone	Hi

1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.

2️⃣ Action items. To be added later.

3️⃣ Statistics

benjifisher

Fixed since last week's meeting: 0 (not counting the issue for the meeting). RTBC: 3, 1 of which is Major. NR: 2, 1 of which is Major. Google sheet for recording stats: https://docs.google.com/spreadsheets/d/1o0Rjlc1vnnLP5bM5P-SMMyGzqn7258hi...

4️⃣ Comment in this thread if you are looking for ways to help. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...

5️⃣ Previous minutes.

benjifisher	Two weeks ago was the quarterly video meeting.#3477036: [meeting] Migrate Meeting 2024-10-10 2100Z is Fixed.
benjifisher	Two weeks before that, we still need to add a transcript to the meeting:#3473711: [meeting] Migrate Meeting 2024-09-26 1400Z
Dan Davis	I added the transcript for 2024-09-26, you may want to give it a review to make sure all the links made it over correctly.
benjifisher	Will do. Thanks!

6️⃣ Announcements

benjifisher

I am in Oakland, CA today for BADCamp: https://www.badcamp.org/

7️⃣ Import CSV Recipe

benjifisher	https://www.drupal.org/project/import_csv
benjifisher	This is my first recipe. It uses `migrate_plus`, `migrate_source_ui`, and `migrate_source_csv` and comes with 3 migrations so that you can import (and update) users, terms, and nodes from a CSV file.
benjifisher	Thanks to @heddn for maintaining those modules and for help with two issues. This one is already Fixed, and should be part of the next release:#3480275: File validation changed in Drupal 10.2
benjifisher	This one NR:#3480434: Allow /dev/null as the source path
thejimbirch	Recipe looks great!

8️⃣ Convert MigrateSource plugin discovery to attributes

benjifisher	https://www.drupal.org/project/drupal/issues/3421014
benjifisher	@quietone: The priority is Normal. Should it be Major?
benjifisher	@godotislate: I see a lot of commits on 2024-09-27. The issues status is still NW. Should it be NR?
benjifisher	Or if NW is accurate, what needs to be done next?
godotislate	see the Remaining tasks in the IS Determine which approach is the best way forward (between MR 6780, MR 9571, or 8070)
godotislate	if Needs Review is more apt, I can change it
benjifisher	Thanks. I will take a look. This thread may be a good place for the discussion.
godotislate	changed to NR and edited the Proposed resolution to separate the three different strategies more clearly
benjifisher	The issue summary still says, There was work to covert MigrateSource discovery to attributes with multiple providers previously done in #3424509: Update MigratePluginManager to include both attribute and annotation class, but was reverted for an issue with the source_module property in the attribute. That work has been restored here, with a few changes to address additional complications, mostly because of multiple providers: ... I see three commits on the 11.x branch: $ git hist --grep=3424509 * 7dd6b190eb8 2024-04-05 \| Issue #3424509 by godotislate, quietone, sorlov, smustgrave, alexpott, benjifisher: Update MigratePluginManager to include both attribute and annotation class [Alex Pott] * 580bfcb702e 2024-04-04 \| Revert "Issue #3424509 by godotislate, quietone, sorlov, smustgrave, benjifisher, alexpott: Update MigratePluginManager to include both attribute and annotation class" [quietone] * c9d53fd473a 2024-04-04 \| Issue #3424509 by godotislate, quietone, sorlov, smustgrave, benjifisher, alexpott: Update MigratePluginManager to include both attribute and annotation class [Alex Pott] The second commit reverts the first one, and it looks as though the third commit restores most of that work.
godotislate	that history is just background
godotislate	basically, 6780 is the approach to move everything
benjifisher	I was confused. Reading that, I thought this issue was re-doing all the work of the previous issue and then more. But I can reword it myself, now that I have looked at the git record.
benjifisher	Which approach do you think it best?
godotislate	at this point, I don't know
godotislate	9571 is probably the "fastest" way to get over the line
godotislate	and meets @mikelutz (he/him)’s suggestions
benjifisher	basically, 6780 is the approach to move everything Can you say a little more? According to the summary,#3458177: Changing plugins from annotations to attributes in contrib leads to error if plugin extends from a missing dependency already moved several things to `migrate_drupal`.
godotislate	it's covered in "Proposed resolution", unless you need more clarity
	https://www.drupal.org/project/drupal/issues/3458177 did not move anything in `migrate_drupal`. It just handles plugin discovery exceptions
benjifisher	Under Problem/Motivation: That work has been restored here, with a few changes to address additional complications, mostly because of multiple providers: ...I18nQueryTrait, has been moved from content_translation to migrate_drupal. ... Maybe that should be in the Proposed Resolution section. If some of that is common to all three MRs, then put it at the top.
godotislate	fair enough
benjifisher	I have a lot more work to do: read the comments on #3009349: Revert migrate_drupal source annotations to attributes conversion and look at the code in the three MRs. I will try to get started in the next few days.
godotislate	yeah, I can rewrite the IS in the meantime
benjifisher	My initial thoughts, based on this thread and the issue summary are Moving code into migrate_drupal is a good thing. That will make it easier to remove that module (and everything that depends on it) in D12. Creating temporary files to instantiate classes from uninstalled modules seems like it is asking for trouble.
godotislate	I guess another solution is to move all d6/d7 source plugins to `migrate_drupal` , with the existing classes extending the new `migrate_drupal` classes. A deprecation message that the plugins are going away can be added either here or in separate issue about preparing for migrate`_drupal` removal (edited)
godotislate	I've updated the IS. Hopefully it is more clear now (edited)
quietone	I am sure we have an existing agreement to not move all the source plugins to migrate_drupal. I recall the plan is to rely on deprecating DrupalSqlBase.
quietone	Yes, it is mentioned in this issue summary, https://www.drupal.org/project/drupal/issues/3315257

9️⃣ migrate mapping & messages table names are truncated, can lead to incorrect mapping lookups

benjifisher	https://www.drupal.org/project/drupal/issues/2845340
benjifisher	Status NR, priority Major.
benjifisher	IIRC, one approach on this issue involved renaming database tables in an update hook. I hope we have a safer approach now.