Problem/Motivation

Part of enabling the sniff Drupal.Commenting.FunctionComment.MissingParamType.

This is for the $form, $form_state and $form_id, which should all be the same.

Steps to reproduce

Proposed resolution

Add the missing param type for form, form_state and form_id. And while touching the file also add the comment.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3478166

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !9715

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review
quietone’s picture

quietone commented
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Reviewed the changes and the typehints line up with the variables being updated.

LGTM

mstrelan’s picture

mstrelan commented
Status: Reviewed & tested by the community » Needs work

One $form_id is typed as array instead of string

quietone’s picture

quietone commented
Status: Needs work » Needs review

@mstrelan, thanks.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback appears to be addressed.

  • catch committed e302022d on 10.3.x 
    Issue #3478166 by quietone, smustgrave, mstrelan: Add MissingParamType...

  • catch committed 01f864cc on 10.4.x 
    Issue #3478166 by quietone, smustgrave, mstrelan: Add MissingParamType...

  • catch committed dd3beacc on 11.x 
    Issue #3478166 by quietone, smustgrave, mstrelan: Add MissingParamType...

  • catch committed 4b0a1636 on 11.0.x 
    Issue #3478166 by quietone, smustgrave, mstrelan: Add MissingParamType...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!

catch closed merge request !9715

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.