Problem/Motivation

Part of #3427903: [META] Make Drupal 10/11 compatible with PHP 8.4

As of 10.5.35 Deprecation of the E_STRICT constant in PHP 8.4

Proposed resolution

upgrade and backport to 10.4.x as all major versions got this fix https://github.com/sebastianbergmann/phpunit/commit/d7d8e73cfc78788ff6c7...

Remaining tasks

review, commit

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3477361

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andypost created an issue. See original summary.

andypost opened merge request !9656

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
Issue tags: +Barcelona2024
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

See no reason not to and didn't cause any test failures.

  • longwave committed 23174b70 on 11.x 
    Issue #3477361: Update phpunit/phpunit to 10.5.35 for PHP 8.4
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 10.4.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed 23174b7 and pushed to 11.x. Thanks!

Not sure this is worth backporting to 11.0.x, we probably will not fix all PHP 8.4 deprecations there anyway?

10.4.x is still on PHPUnit 9, seems like there we need to go to PHPUnit 9.6.21 - leaving open to make that change.

andypost closed merge request !9656

andypost opened merge request !9662

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Update phpunit/phpunit to 10.5.35 for PHP 8.4 » Update phpunit/phpunit to 9.6.21 for PHP 8.4
Status: Patch (to be ported) » Needs review

Thank you!

Prepared upgrade for 10.4 but it needs to update phpunit using -W argument, also re-title for actual version

+---------------------------+--------+--------+
| Dev Changes               | From   | To     |
+---------------------------+--------+--------+
| myclabs/deep-copy         | 1.11.1 | 1.12.0 |
| nikic/php-parser          | v5.0.2 | v5.2.0 |
| phpunit/php-code-coverage | 9.2.31 | 9.2.32 |
| phpunit/phpunit           | 9.6.19 | 9.6.21 |
+---------------------------+--------+--------+
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

10.4 version didn't seem to cause any issues

  • longwave committed d345bae5 on 10.4.x 
    Issue #3477361 by andypost: Update phpunit/phpunit to 9.6.21 for PHP 8.4
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed d345bae and pushed to 10.4.x. Thanks!

@andypost somehow I did not credit you for the 11.x commit, sorry for that - fixed for 10.4.x and saving credits here.

andypost’s picture

andypost
he/him
Primary language Russian
commented

@longwave Thank you! NP for credits - it unblocks testing!

andypost closed merge request !9662

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.