Problem/Motivation
Right now, the recipe system validates everything in the config.actions section of recipe.yml, trying to confirm that every module mentioned in that section (i.e., in the prefix of the config entities' names) is either installed already, or will be installed by a recipe in the stack.
That's a bit too strict -- required modules should not need to be listed, because they are always guaranteed to be installed. Fixing this will allow Recipe objects to be instantiated during the early installer, which is important for Drupal CMS.
Proposed resolution
In \Drupal\Core\Recipe\Recipe::validateConfigActions(), treat required modules as installed, even if they're not. Because we know they will be.
Issue fork drupal-3477329
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
thejimbirch commentedComment #3
phenaproximaComment #4
phenaproximaComment #8
phenaproximaComment #9
phenaproximaComment #11
b_sharpe commentedSmall typo and suggestion. Code is fine.
Comment #12
phenaproximaAdded test coverage. I think this is good to go!
Comment #13
thejimbirch commentedLooks fine to me. Appreciate @b_sharpe for also reviewing! Marking RTBC
Comment #14
alexpottComment #15
alexpottCommitted and pushed 81f055eb1ca to 11.x and 69e817f5330 to 11.0.x and 326f814f5c1 to 10.4.x and c371e81a32f to 10.3.x. Thanks!
Comment #16
alexpott