Problem/Motivation
This is one of the slowest functional JS tests and easily takes 180s on gitlab, although only about 35s on my local.
There are three test methods that make zero changes to the install and just request three different pages that expose three different potential issues - these can be consolidated to one test method and three protected methods so we cut the number of Drupal installs from 5 to 3.
Before:
Time: 00:34.639, Memory: 4.00 MB
OK (5 tests, 29 assertions)
After:
OK (3 tests, 25 assertions)
Time: 00:26.339, Memory: 4.00 MB
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3468827
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3468827-speed-up-bigpiperegressiontest
changes, plain diff MR !9245
Comments
Comment #3
catchComment #4
smustgrave commentedBelieve the 1 test failure is random.
Appears no test coverage has been lost.
Have to mention. doTestPlaceholderInParagraph_2802923 just feels gross haha.
Comment #10
nod_Committed and pushed aae2ffb6ac to 11.x and 6469237268 to 11.0.x and 1c15c0f3ba to 10.4.x and b057373142 to 10.3.x. Thanks!