Problem/Motivation

Update minor and patch releases of JavaScript dependencies for 11.0.0

- Major release are handled in separate issues (and might not be eligible to update for an update anyway, unsure about the policy on this between an RC and full release?).
- Both jquery and jquery-ui have their own issue already for getting to a stable release: #3449874: Update to jQuery 4.0.0 and #3449875: Update to jQuery UI 1.14.0
- Nightwatch update lives here: #3371963: Update Nightwatch to 3.x
- eslint update is here: #3440225: Update to ESLint v9 with standard rules
-

Bah, we can't update stylelint because of stylelint-formatter-gitlab: https://gitlab.com/leon0399/stylelint-formatter-gitlab/-/issues/3

@longwave in #3439522-16: Update JavaScript dependencies for Drupal 10.3/11.0

Steps to reproduce

$ yarn upgrade-interactive

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3465166

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Spokje created an issue. See original summary.

spokje’s picture

Issue tags: +Needs followup

-

Bah, we can't update stylelint because of stylelint-formatter-gitlab: https://gitlab.com/leon0399/stylelint-formatter-gitlab/-/issues/3

@longwave in #3439522-16: Update JavaScript dependencies for Drupal 10.3/11.0

I think we need an issue to decide if stylelint-formatter-gitlab should be considered abandoned and look for alternatives.

I found a JS alternative here: #3460114-7: Update JavaScript dependencies for Drupal 11.0-rc, but there should/might be easier ways.

Anyway, doesn't seem right we don't update a dependency "simply" because the reporting can't handle the update.

spokje’s picture

Issue summary: View changes
spokje’s picture

Issue summary: View changes
spokje’s picture

Issue summary: View changes

spokje’s picture

Great stuff...

Seems that floating-ui was never updated in our core/assets/vendor when using yarn vendor-update, because it has no entry in core/scripts/js/vendor-update.js const ASSET_LIST...

spokje’s picture

Should have fixed the above, but me thinks we need another follow-up to create a test that makes sure all our JS-assets are actually updated when doing a yarn vendor-update.

spokje’s picture

Although prettier was updated, a $ yarn prettier shows no changes.

nod_ made their first commit to this issue’s fork.

nod_’s picture

fixed up the floating ui declaration, no need to mess with the processing :)

spokje’s picture

Thanks @_nod

spokje’s picture

Since we're using a new version of cspell, also did a $ yarn spellcheck:make-dict.

spokje’s picture

Assigned: spokje » Unassigned
Status: Active » Needs review
xjm’s picture

I imagine this will probably conflict with #3371963: Update Nightwatch to 3.x. I'm not sure what to do about that issue, but it should take precedence since a major version upgrade of Nightwatch is a significant thing for core maintenance (and will likely slip to D12 otherwise).

xjm’s picture

xjm’s picture

Discussed with @longwave and we might do the Nightwatch 3 update in 11.1, which would mean this could still go in today before 11.0.0 (should it be RTBCed).

nod_’s picture

Status: Needs review » Reviewed & tested by the community

floating ui is used by navigation and the update didn't break anything.
underscore just updated the license data, no code changes.
build/lint scripts didn't change

  • xjm committed 067dd631 on 11.x
    Issue #3465166 by Spokje, nod_: Update JavaScript dependencies for...

  • xjm committed d0da23b5 on 11.0.x
    Issue #3465166 by Spokje, nod_: Update JavaScript dependencies for...
xjm’s picture

Version: 11.x-dev » 11.0.x-dev

I checked the following to ensure there were no diffs from the MR:

cd core
yarn install
yarn spellcheck:make-dict
yarn run build
yarn prettier

...And of course CSS and JS linting happen in my pre-commit hook.

When I cherry-picked it to 11.0.x and repeated the above, there was one additional misspelling:

[ayrton:core | Thu 16:27:41] $ git diff
diff --git a/core/misc/cspell/dictionary.txt b/core/misc/cspell/dictionary.txt
index 79e14b2a06..232320fd08 100644
--- a/core/misc/cspell/dictionary.txt
+++ b/core/misc/cspell/dictionary.txt
@@ -710,6 +710,7 @@ untabbable
 upcasted
 upcasting
 updateprogress
+uploaders
 uploadprogress
 upscaling
 urandom

This is found in:
core/modules/update/src/Form/UpdateManagerInstall.php: $test_authorize = \Drupal::state()->get('test_uploaders_via_prompt', FALSE);
...which was deleted in #3417136: Remove adding an extension via a URL, so I amended the 11.0.x cherry-pick to add it back to the dictionary. Probably a problem with the previous commit rather than new versions of dependencies here, but I amended the commit anyway so that the linting tests don't fail on 11.0.x:

[ayrton:maintainer | Thu 16:36:12] $ cd core
[ayrton:core | Thu 16:36:15] $ yarn spellcheck:make-dict
[ayrton:core | Thu 16:36:30] $ cd ..
[ayrton:maintainer | Thu 16:38:00] $ git diff
diff --git a/core/misc/cspell/dictionary.txt b/core/misc/cspell/dictionary.txt
index 79e14b2a06..232320fd08 100644
--- a/core/misc/cspell/dictionary.txt
+++ b/core/misc/cspell/dictionary.txt
@@ -710,6 +710,7 @@ untabbable
 upcasted
 upcasting
 updateprogress
+uploaders
 uploadprogress
 upscaling
 urandom
[ayrton:maintainer | Thu 16:38:01] $ git add core/misc/cspell/dictionary.txt
[ayrton:maintainer | Thu 16:38:30] $ git commit --amend -m 'Issue #3465166 by Spokje, nod_: Update JavaScript dependencies for Drupal 11.0.0'

Then confirmed re-running the dictionary build did not result in additional changes.

Thanks!

xjm’s picture

Status: Reviewed & tested by the community » Fixed

Do we still need that followup about stylelint-formatter-gitlab?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.