Problem/Motivation
Update minor and patch releases of JavaScript dependencies for 11.0.0
- Major release are handled in separate issues (and might not be eligible to update for an update anyway, unsure about the policy on this between an RC and full release?).
- Both jquery and jquery-ui have their own issue already for getting to a stable release: #3449874: Update to jQuery 4.0.0 and #3449875: Update to jQuery UI 1.14.0
- Nightwatch update lives here: #3371963: Update Nightwatch to 3.x
- eslint update is here: #3440225: Update to ESLint v9 with standard rules
-
Bah, we can't update stylelint because of stylelint-formatter-gitlab: https://gitlab.com/leon0399/stylelint-formatter-gitlab/-/issues/3
@longwave in #3439522-16: Update JavaScript dependencies for Drupal 10.3/11.0
Steps to reproduce
$ yarn upgrade-interactive
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3465166
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3465166-update-javascript-dependencies
changes, plain diff MR !9020
Comments
Comment #2
spokje-
@longwave in #3439522-16: Update JavaScript dependencies for Drupal 10.3/11.0
I think we need an issue to decide if
stylelint-formatter-gitlabshould be considered abandoned and look for alternatives.I found a JS alternative here: #3460114-7: Update JavaScript dependencies for Drupal 11.0-rc, but there should/might be easier ways.
Anyway, doesn't seem right we don't update a dependency "simply" because the reporting can't handle the update.
Comment #3
spokjeComment #4
spokjeComment #5
spokjeComment #7
spokjeGreat stuff...
Seems that
floating-uiwas never updated in ourcore/assets/vendorwhen usingyarn vendor-update, because it has no entry incore/scripts/js/vendor-update.jsconst ASSET_LIST...Comment #8
spokjeShould have fixed the above, but me thinks we need another follow-up to create a test that makes sure all our JS-assets are actually updated when doing a
yarn vendor-update.Comment #9
spokjeAlthough
prettierwas updated, a$ yarn prettiershows no changes.Comment #11
nod_fixed up the floating ui declaration, no need to mess with the processing :)
Comment #12
spokjeThanks @_nod
Comment #13
spokjeSince we're using a new version of cspell, also did a
$ yarn spellcheck:make-dict.Comment #14
spokjeComment #15
xjmI imagine this will probably conflict with #3371963: Update Nightwatch to 3.x. I'm not sure what to do about that issue, but it should take precedence since a major version upgrade of Nightwatch is a significant thing for core maintenance (and will likely slip to D12 otherwise).
Comment #16
xjmComment #17
xjmDiscussed with @longwave and we might do the Nightwatch 3 update in 11.1, which would mean this could still go in today before 11.0.0 (should it be RTBCed).
Comment #18
nod_floating ui is used by navigation and the update didn't break anything.
underscore just updated the license data, no code changes.
build/lint scripts didn't change
Comment #21
xjmI checked the following to ensure there were no diffs from the MR:
...And of course CSS and JS linting happen in my pre-commit hook.
When I cherry-picked it to 11.0.x and repeated the above, there was one additional misspelling:
This is found in:
core/modules/update/src/Form/UpdateManagerInstall.php: $test_authorize = \Drupal::state()->get('test_uploaders_via_prompt', FALSE);...which was deleted in #3417136: Remove adding an extension via a URL, so I amended the 11.0.x cherry-pick to add it back to the dictionary. Probably a problem with the previous commit rather than new versions of dependencies here, but I amended the commit anyway so that the linting tests don't fail on 11.0.x:
Then confirmed re-running the dictionary build did not result in additional changes.
Thanks!
Comment #22
xjmDo we still need that followup about
stylelint-formatter-gitlab?Comment #24
spokjeOpened #3467309: Replace abandoned, not working with latest stylelint, leon0399/stylelint-formatter-gitlab with gitlab-formatters/stylelint-formatter-gitlab