Hi,
this patch adds missing documentation of the hook_update_last_removed() as well as some minor improvements to the description of hook_update_N().
Regards,
Tobias
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | fix-link-syntax.patch | 2.02 KB | toddy |
| #5 | fix-link-syntax.patch | 2 KB | toddy |
| hook_update_last_removed.patch | 2.68 KB | toddy |
Comments
Comment #1
dave reidSeems like this could be a valid hook, although it is only implemented by system.install:
I would classify this as minor, since we haven't even noticed that this was possibly a hook.
Comment #2
catchI vaguely remember the issue this was added, and it is indeed supposed to be a hook, the docs look good, so RTBC.
Comment #3
webchickAwesome! Committed to HEAD!
This also needs to be committed to the 6.x (and possibly 5.x) upgrade documentation at contributions/docs/developer/hooks/core.php.
However, this is something that anyone with a CVS account can do, not just Gábor.
Comment #4
dave reidCommitted to 6.x and 5.x
Comment #5
toddy commentedUnfortunately, the syntax for @link is a bit different from the original Doxygen syntax, so the links do not work as expected. This patch should fix the problem.
Regards,
Tobias
Comment #6
dave reidYou can view what's currently being not linked at http://api.drupal.org/api/function/hook_update_N/7. Looks good.
Comment #8
dave reidAh... make sure to run diff -uRp from the root drupal directory.
Comment #9
toddy commentedSorry for this. The patch should now apply.
Comment #10
webchickAwesome, thanks! Committed to HEAD.
Could someone commit the same to 5.x/6.x?
Comment #11
webchickOops. Leaving at RTBC, just wanted to move version down.
Comment #12
gábor hojtsyhook_update_last_removed() was not in 5.x, so it was a mistake to add it to the 5.x documentation in #4.
- The 5.x commit of hook_update_last_removed() should be reverted.
- #9 should be applied to the 6.x documentation.
Comment #13
gábor hojtsyBTW hook_update_last_removed was introduced here: #194310: Check / run updates of disabled modules
Comment #14
jhodgdonGracious.
I just took care of #12.