Problem/Motivation

In this issue was added some css:

https://www.drupal.org/project/drupal/issues/3445993

https://git.drupalcode.org/project/drupal/-/merge_requests/8011#note_316513

Proposed resolution

1. Remove unnecessary cascade.
2. Probably remove that last-of-type selector and add it to padding-bottom.

Issue fork drupal-3450103

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

finnsky created an issue. See original summary.

finnsky’s picture

finnsky commented
Status: Active » Postponed

Let's start when parent feature will be merged.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Title: .admin-toolbar__footer CSS fix. [follow up] » [PP-1] .admin-toolbar__footer CSS fix. [follow up]
finnsky’s picture

finnsky commented
Status: Postponed » Active

Parent issue merged

rsnyd made their first commit to this issue’s fork.

rsnyd’s picture

rsnyd
Primary language English
Location Northeast Pennsylvania
commented
Title: [PP-1] .admin-toolbar__footer CSS fix. [follow up] » .admin-toolbar__footer CSS fix. [follow up]
Assigned: Unassigned » rsnyd

Working on this.

rsnyd’s picture

rsnyd
Primary language English
Location Northeast Pennsylvania
commented

In this note (https://git.drupalcode.org/project/drupal/-/merge_requests/8011#note_316513), if I understand correctly, @finnsky asks for the margin-block-end style to be changed to padding-bottom and added to the .admin-toolbar__footer rule, as opposed to the .admin-toolbar__footer > .toolbar-block:last-of-type where it currently resides.

If this is all true, the spacing would occur after the collapse button (.admin-toolbar__expand-button) rather than between the 'Help' and 'username' links as it does now. So should I add the padding to the bottom of the .admin-toolbar__footer or to the 'username' link?

Working on this as a novice to become more familiar with contributing. Thank you for any feedback/advise/criticisms.

rsnyd opened merge request !10068

rsnyd’s picture

rsnyd
Primary language English
Location Northeast Pennsylvania
commented
Status: Active » Needs review

I have made the small change as I understood it. Please let me know if it needs any updates.

rsnyd’s picture

rsnyd
Primary language English
Location Northeast Pennsylvania
commented
Assigned: rsnyd » Unassigned
finnsky’s picture

finnsky commented

Thank you for you work here.
I found that this problem a bit deeper than it seems from first view. Added few comments. Not sure yet what to do with this

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Based on the comment sounds like this still needs investigation?

Should novice tag be removed?

jvbrian’s picture

jvbrian commented

Replace the margin-block-end style with padding-bottom and apply it to the .admin-toolbar__footer rule, instead of the current .admin-toolbar__footer > .toolbar-block:last-of-type. A space will appear, but beneath the button that toggles the child items.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.