Image style configuration entity is not yet fully validatable:
vendor/bin/drush config:inspect --filter-keys=image.style.large --detail --list-constraints
➜ 🤖 Analyzing…
Legend for Data:
✅❓ → Correct primitive type, detailed validation impossible.
✅✅ → Correct primitive type, passed all validation constraints.
-------------------------------------------------------------------------------- --------- ------------- ------ ---------------------------------------------------------------------------------------------
Key Status Validatable Data Validation constraints
-------------------------------------------------------------------------------- --------- ------------- ------ ---------------------------------------------------------------------------------------------
image.style.large Correct 83% ✅❓ ValidKeys: '<infer>'
image.style.large: Correct Validatable ✅✅ ValidKeys: '<infer>'
image.style.large:_core Correct Validatable ✅✅ ValidKeys:
- default_config_hash
image.style.large:_core.default_config_hash Correct Validatable ✅✅ NotNull: { }
Regex: '/^[a-zA-Z0-9\-_]+$/'
Length: 43
↣ PrimitiveType: { }
image.style.large:dependencies Correct Validatable ✅✅ ValidKeys: '<infer>'
image.style.large:effects Correct NOT ✅❓ ⚠️ @todo Add validation constraints to config entity type: image.style.*
image.style.large:effects.6e8fe467-84c1-4ef0-a73b-7eccf1cc20e8 Correct Validatable ✅✅ ValidKeys: '<infer>'
image.style.large:effects.6e8fe467-84c1-4ef0-a73b-7eccf1cc20e8.data Correct Validatable ✅✅ ValidKeys: '<infer>'
image.style.large:effects.6e8fe467-84c1-4ef0-a73b-7eccf1cc20e8.data.extension Correct NOT ✅❓ ❌ @todo Add validation constraints to ancestor type: image.effect.image_convert
image.style.large:effects.6e8fe467-84c1-4ef0-a73b-7eccf1cc20e8.id Correct Validatable ✅✅ PluginExists:
manager: plugin.manager.image.effect
interface: Drupal\image\ImageEffectInterface
↣ PrimitiveType: { }
image.style.large:effects.6e8fe467-84c1-4ef0-a73b-7eccf1cc20e8.uuid Correct Validatable ✅✅ Uuid: { }
↣ PrimitiveType: { }
image.style.large:effects.6e8fe467-84c1-4ef0-a73b-7eccf1cc20e8.weight Correct Validatable ✅✅ Range:
min: -2147483648
max: 2147483647
FullyValidatable: null
↣ PrimitiveType: { }
image.style.large:effects.ddd73aa7-4bd6-4c85-b600-bdf2b1628d1d Correct Validatable ✅✅ ValidKeys: '<infer>'
image.style.large:effects.ddd73aa7-4bd6-4c85-b600-bdf2b1628d1d.data Correct Validatable ✅✅ ValidKeys: '<infer>'
image.style.large:effects.ddd73aa7-4bd6-4c85-b600-bdf2b1628d1d.data.height Correct NOT ✅❓ ❌ @todo Add validation constraints to ancestor type: image.effect.image_scale
image.style.large:effects.ddd73aa7-4bd6-4c85-b600-bdf2b1628d1d.data.upscale Correct Validatable ✅✅ ↣ PrimitiveType: { }
image.style.large:effects.ddd73aa7-4bd6-4c85-b600-bdf2b1628d1d.data.width Correct NOT ✅❓ ❌ @todo Add validation constraints to ancestor type: image.effect.image_scale
image.style.large:effects.ddd73aa7-4bd6-4c85-b600-bdf2b1628d1d.id Correct Validatable ✅✅ PluginExists:
manager: plugin.manager.image.effect
interface: Drupal\image\ImageEffectInterface
↣ PrimitiveType: { }
image.style.large:effects.ddd73aa7-4bd6-4c85-b600-bdf2b1628d1d.uuid Correct Validatable ✅✅ Uuid: { }
↣ PrimitiveType: { }
image.style.large:effects.ddd73aa7-4bd6-4c85-b600-bdf2b1628d1d.weight Correct Validatable ✅✅ Range:
min: -2147483648
max: 2147483647
FullyValidatable: null
↣ PrimitiveType: { }
image.style.large:label Correct Validatable ✅✅ Regex:
pattern: '/([^\PC])/u'
match: false
message: 'Labels are not allowed to span multiple lines or contain control characters.'
NotBlank: { }
↣ PrimitiveType: { }
image.style.large:langcode Correct Validatable ✅✅ NotNull: { }
Choice:
callback: 'Drupal\Core\TypedData\Plugin\DataType\LanguageReference::getAllValidLangcodes'
↣ PrimitiveType: { }
image.style.large:name Correct Validatable ✅✅ Regex:
pattern: '/^[a-z0-9_]+$/'
message: 'The %value machine name is not valid.'
Length:
max: 166
↣ PrimitiveType: { }
image.style.large:status Correct Validatable ✅✅ ↣ PrimitiveType: { }
image.style.large:uuid Correct Validatable ✅✅ Uuid: { }
↣ PrimitiveType: { }
-------------------------------------------------------------------------------- --------- ------------- ------ ---------------------------------------------------------------------------------------------
11.x.composer require drupal/config_inspector — or manually install https://www.drupal.org/project/config_inspector/releases/2.1.5 or newer (which supports Drupal 11!)composer require drush/drushvendor/bin/drush config:inspect --filter-keys=image.style.large --detail --list-constraintsAdd validation constraints to missing properties.
This requires looking at the existing code and admin UI (if any) to understand which values could be considered valid. Eventually this needs to be reviewed by the relevant subsystem maintainer.
For examples, search *.schema.yml files for the string constraints: 😊
Reach out to @borisson_ or @wimleers in the #distributions-and-recipes.
None.
None.
More validation 🚀
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | Screenshot 2024-05-20 at 10.32.48 AM.png | 82.78 KB | smustgrave |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !8084
Comments
Comment #3
narendrarComment #4
smustgrave commentedThought maybe we would need an upgrade path for image effects without weight.
But did a quick check on 11.x and 10.3.x I see that weight is already included so assuming these were just missed test updates.
Rest of the changes look good. Using config inspector on 10.3.x I see all green now too. Attaching screenshot
Comment #6
catchCommitted/pushed to 11.x, thanks!
I don't think this is beta-eligible (e.g. it could break contrib tests that need similar changes) and I don't think it is an obvious candidate for backport to 10.4.x because it's not adding a new API, so leaving in (what will be) 11.1.x for now.