Problem/Motivation

There are 3 NavigationBlock plugin provided by Navigation module: NavigationMenuBlock, NavigationShortcutsBlock & UserNavigationBlock.

The later follow a different name pattern, nd would be great to have a single naming convention for these blocks.

Proposed resolution

  • Rename class UserNavigationBlock to NavigationUserBlock
  • Rename class UserNavigationBlockTest to NavigationUserBlockTest
  • Remove unused class property moduleHandler which is not being used while we are here

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3446116

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Issue summary: View changes
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Title: Rename UserNavigationBlock to NavigationUserBlock for consistencyy » Rename UserNavigationBlock to NavigationUserBlock for class name consistency
sjothivelu’s picture

sjothivelu commented
Assigned: Unassigned » sjothivelu

Hi,

I can work on this issue.

sjothivelu@valleywater.org opened merge request !7984

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Issue summary: View changes
Status: Active » Needs work

Thank you for working on this one!

Would be great if you could merge 11.x branch into the MR branch to fix the broken tests. They're unrelated to the issue, but to the specific 11.x HEAD you used as base.

While we are here, would be great if you could remove the moduleHandler property from the NavigationUserBlock class.

You can completely remove __construct() & create() methods. We could also get rid of the reference to ContainerFactoryPluginInterface in the class definition.

Thank you!

m4olivei made their first commit to this issue’s fork.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: sjothivelu » Unassigned
Status: Needs work » Needs review

I've merged 11.x and made the changes requested in #6. Tests are now passing.

Ready for review.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

Thank you both for taking care of it!

I think we can mark this as RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!

  • catch committed b09d4e08 on 10.3.x 
    Issue #3446116 by sjothivelu, m4olivei, plopesc: Rename...

  • catch committed 9004361a on 10.4.x 
    Issue #3446116 by sjothivelu, m4olivei, plopesc: Rename...

  • catch committed f05c0962 on 11.0.x 
    Issue #3446116 by sjothivelu, m4olivei, plopesc: Rename...

  • catch committed 0de488c1 on 11.x 
    Issue #3446116 by sjothivelu, m4olivei, plopesc: Rename...

catch closed merge request !7984

catch’s picture

catch
he/him
Primary language English
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.