Problem

In core's MR, there has been a regression and the Shortcuts module is flickering again.

Proposed resolution

Fix the flickering

CommentFileSizeAuthor
#19 284771c1a9983d334c94ee3e7608bd49.gif239.44 KBfinnsky
flickering.gif512.79 KBckrina

Issue fork drupal-3443559

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

ckrina created an issue. See original summary.

ckrina’s picture

ckrina credited lauriii.

ckrina’s picture

mherchel’s picture

Ten bucks says this is caused by BigPipe injecting the data. Should be able to be fixed with https://www.drupal.org/node/3338948 with a similar technique as #3441137: BigPipe injecting Local Actions block creates large janky layout shift in Claro

mherchel’s picture

Confirmed that it is BigPipe. Everyone now owes me $10.

This isn't a beta-blocker, so let's fix this after it gets into core (which should be very soon).

plopesc’s picture

Thank you for being able to capture the glitch!

For reference: This flickering was introduced as part of this comment in the main core
MR:https://git.drupalcode.org/project/drupal/-/merge_requests/7474#note_297577

Need to find a way to have a cacheable placeholder to avoid flickering.

It affects to user navigation block as well, but it's less noticeable, given that's in the footer.

We could consider this a duplicated of #3443452: [PP-1] User menu block render array is cached per user or vice-versa.

ckrina’s picture

Project: Navigation » Drupal core
Version: 1.x-dev » 11.x-dev
Component: Code » navigation.module
mherchel’s picture

Issue tags: +Portland2024

mherchel’s picture

Status: Active » Needs review
mariacha1’s picture

I'm working on this ticket as part of the Drupal2024 First Time Contributor workshop and am mentoring a few people who will say hello below!

We're going to be reviewing this patch.

yojohnyo’s picture

I will be taking a look at this.

sjothivelu’s picture

Hello,
I am going to be testing on this issue!

-Sara

finnsky’s picture

Thank fo fix. One suggestion added

finnsky’s picture

Status: Needs review » Needs work
mherchel’s picture

Status: Needs work » Needs review

@finnsky Good call! Fixed and ready for review.

finnsky’s picture

Status: Needs review » Reviewed & tested by the community

Yay, no any flickering in menu anymore. Thank you!

finnsky’s picture

StatusFileSize
new239.44 KB

flick

nod_’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed c0beeeea5f to 11.x and 6974f8b7f0 to 11.0.x and 04fad10830 to 10.4.x and 2237b2eed8 to 10.3.x. Thanks!

  • nod_ committed 2237b2ee on 10.3.x
    Issue #3443559 by mherchel, ckrina, finnsky, lauriii: Regression:...

  • nod_ committed 04fad108 on 10.4.x
    Issue #3443559 by mherchel, ckrina, finnsky, lauriii: Regression:...

  • nod_ committed 6974f8b7 on 11.0.x
    Issue #3443559 by mherchel, ckrina, finnsky, lauriii: Regression:...

  • nod_ committed c0beeeea on 11.x
    Issue #3443559 by mherchel, ckrina, finnsky, lauriii: Regression:...
nod_’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.