Problem/Motivation

The standardized SPDX (System Package Data Exchange) license identifiers are used by many other projects in various places, such as package.json and composer.json files, and I'd say Drupal should use these standard identifiers too. See https://spdx.org/licenses/

Drupal uses GNU-GPL-2.0-or-later, this should be shortened to simply GPL-2.0-or-later

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3437783

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mfb created an issue. See original summary.

mfb opened merge request !7298

mfb’s picture

mfb
they or he
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Make sense. Applied MR and searched for GNU-GPL-2.0-or-later and seems everything has been replaced.

Not sure this needs any kind of sign off or not but going to mark.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

I think adopting this standard is a good idea, and we could document this in LibraryDiscoveryParser for the name field:

   * - license: If the remote property is set, the license information is
   *   required. It has 3 properties:
   *   - name: The human-readable name of the license.
   *   - url: The URL of the license file/information for the version of the
   *     library used.
   *   - gpl-compatible: A Boolean for whether this library is GPL compatible.

pradhumanjain2311 made their first commit to this issue’s fork.

mfb’s picture

mfb
they or he
commented
Status: Needs work » Needs review

Added documentation to resolve #5

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Description added by @mfb reads well.

catch made their first commit to this issue’s fork.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Rebased to check if this fails the new performance asset size coverage and it does - we're sending less bytes because the license information is included in the CSS aggregates, and it's now shorter - just needs the assertions updating.

mfb’s picture

mfb
they or he
commented
Status: Needs work » Needs review

Tests are passing

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

  • catch committed 135e3ba1 on 11.x 
    Issue #3437783 by mfb, pradhumanjain2311: Use standardized SPDX license...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to 11.x, thanks!

This doesn't cherry-pick cleanly to 10.3.x so will need a backport MR.

mfb opened merge request !7397

mfb’s picture

mfb
they or he
commented
Status: Patch (to be ported) » Needs review

Backport ready for review

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Backport looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e3da4cc and pushed to 10.3.x. Thanks!

  • alexpott committed e3da4cc3 on 10.3.x 
    Issue #3437783 by mfb, catch, pradhumanjain2311, longwave: Use...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mfb closed merge request !7397

mfb closed merge request !7298