Problem/Motivation

Method onConsecutiveCalls() of class PHPUnit\Framework\TestCase is deprecated in PHPUnit 10

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3433089

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !7165

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

Same ol' same ol':
Replacement makes sense, couldn't find any other occurrences than the ones in the MR, Green tests => RTBC.

mondrake’s picture

mondrake
Location 🇮🇹
commented

I know it’s a bit of a nuisance all these mini-issues, but I learned bigger ones just take too much review effort and then time to get through…

spokje’s picture

spokje
Primary language Dutch
commented

Oh no, I very much like this approach.

My comment was just meant to try to amuse myself whilst c/p-ing my previous RTBC messages.

The problem here is my lousy jokes and your great work, which makes me not able to fault any of it :)

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

+1 to doing it this way, makes it much easier for reviewers and committers :)

mondrake’s picture

mondrake
Location 🇮🇹
commented

No worries about the jokes... I'll start doing lousy work then 😂

mondrake’s picture

mondrake
Location 🇮🇹
commented
Version: 10.3.x-dev » 11.x-dev
spokje’s picture

spokje
Primary language Dutch
commented

I'll start doing lousy work then

Ah, doing lousy work, the foundation of my whole career... ;)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed a1699fe0de to 11.x and 71b8f1cf09 to 10.3.x. Thanks!

  • alexpott committed 71b8f1cf on 10.3.x 
    Issue #3433089 by mondrake: Method onConsecutiveCalls() of class PHPUnit...

  • alexpott committed a1699fe0 on 11.x 
    Issue #3433089 by mondrake: Method onConsecutiveCalls() of class PHPUnit...

mondrake closed merge request !7165

mondrake’s picture

mondrake
Location 🇮🇹
commented

doing lousy work, the foundation of my whole career

🔝😂

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.