Needs work
Project:
Drupal core
Version:
main
Component:
filter.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Feb 2024 at 22:20 UTC
Updated:
10 Mar 2024 at 22:21 UTC
Jump to comment: Most recent
Comments
Comment #2
mstrelan commentedComment #4
mstrelan commentedFirst pass, see what the test bot thinks. Still a few references to the legacy consts and some deprecation to do.
Comment #5
mstrelan commentedHave put in some @todos where I think we can trigger deprecations. We should also have a test module using the old constants in the plugin annotations.
Also adding #3421012: Convert Filter plugin discovery to attributes as related.
Comment #6
wim leersYes, please!
This looks fantastic!
I posted an idea for how to deal with the
getFilterType()return type conundrum. Not 100% sure yet if it'll work, but it's a start :DComment #7
wim leers#3421012: Convert Filter plugin discovery to attributes landed, let's push this forward again?
Comment #8
mstrelan commentedRebased on 11.x and updated the attribute to expect the enum instead of int. Hopefully we don't have to deprecate passing an int to in the attribute if we can get this out before a 10.3 release? Needs work to address the feedback from Wim.