Problem/Motivation

Follow up to #3353210-30: [PHPUnit 10] @dataProvider methods must be declared static and public.

Convert ComposerIntegrationTest::providerTestComposerJson and its helpers to static methods.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3422362

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !6670

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +PHPUnit 10
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Seems straight forward and didn't break anything.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Needs a reroll.

Spokje made their first commit to this issue’s fork.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Rebased

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 72a22d841d to 11.x and f316821d4a to 10.3.x. Thanks!

Didn;t backport to 10.2.x because it did not cherry-pick cleanly.

  • alexpott committed f316821d on 10.3.x 
    Issue #3422362 by mondrake, Spokje, smustgrave: Change...

  • alexpott committed 72a22d84 on 11.x 
    Issue #3422362 by mondrake, Spokje, smustgrave: Change...

mondrake closed merge request !6670

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.