Problem/Motivation

DrupalCI had an "updated deps" job which ran composer update before running the tests. It would be useful to be able to optionally do this on GitLab CI as well.

Steps to reproduce

Proposed resolution

Add a new job that recursively calls the top level pipeline with an additional variable set that triggers composer update followed by the default set of tests.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3420165

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !6513

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

Think this is ready now. It uses recursion to re-run the top level pipeline with an extra variable which is checked during the Composer build job.

Base pipeline is at https://git.drupalcode.org/project/drupal/-/pipelines/90727 with the new "Updated dependencies" job showing.

Pipeline for that is https://git.drupalcode.org/project/drupal/-/pipelines/90730

Compare the output of the base job https://git.drupalcode.org/project/drupal/-/jobs/775818

PHPStan - PHP Static Analysis Tool 1.10.48

with the updated deps job https://git.drupalcode.org/project/drupal/-/jobs/775888

PHPStan - PHP Static Analysis Tool 1.10.57
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I wonder about updating JS dependencies as well, either in the same job or a separate one.

spokje’s picture

spokje
Primary language Dutch
commented

I wonder about updating JS dependencies as well, either in the same job or a separate one.

Was about to type that exact same thing, whilst wanting to open this exact same issue (and probably hopelessly fail on it)

I think it would be a very nice-to-have, at the very least to prevent unneeded/unwanted "surprises" when the time comes for the always-fun "Update JS dependencies for x.y release".

The updated-deps job, which is reincarnated in this issue, saved our asses quite a few times, so I'm a big +1 on a similar updated-js-deps job.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

Wow, very minimal code changes!
Like the addition of showing the version numbers of (the perhaps also updated) PHPCS/PHPStan in the logs.

The "normal" test-run is still green, the failures in the updated-deps run all make sense and are familiar when you hang around (too long/much like me) in various we-need-to-update-this-for-D11 issues.

RTBC for me.

quietone’s picture

quietone commented

I'm triaging RTBC issues. I read the IS, the comments and the MR. I didn't find any unanswered questions or other work to do.

Leaving at RTBC.

  • catch committed 822996f7 on 10.2.x 
    Issue #3420165 by longwave, Spokje: Recreate the "updated deps" job from...

  • catch committed 07af18e8 on 10.3.x 
    Issue #3420165 by longwave, Spokje: Recreate the "updated deps" job from...

  • catch committed c3052fb8 on 11.x 
    Issue #3420165 by longwave, Spokje: Recreate the "updated deps" job from...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

This looks great. Committed/pushed to 11.x, cherry-picked to 10.3.x and 10.2.x to keep things in sync.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.