Problem/Motivation

PHPUnit is deprecating withConsecutive(), so we need to find replacements.

Steps to reproduce

Proposed resolution

We need to assert various cache invalidations happen correctly; we can likely do this in an easier and more readable way with Prophecy.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3418189

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !6398

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

This really makes the test more readable for me, I like that you can spy on things and add expectations in Prophecy throughout the test.

spokje’s picture

spokje
Primary language Dutch
commented

Indeed the test is more readable.

Left a minor nitpick comment on the MR.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Added a similar comment back.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

Thanks! Good enough for me.

  • catch committed 0a61e07e on 11.x 
    Issue #3418189 by longwave, Spokje: Remove withConsecutive() in...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.