Given that Coder implements all core code style + more (best practices, etc.), we should remove code-style.pl.

CommentFileSizeAuthor
#10 empty.patch338 bytesgrendzy
#10 340940_remove_code_style_pl.patch.txt5.29 KBgrendzy
#8 empty.patch1 bytegrendzy
#6 340940_remove_code_style_pl.patch5.29 KBgrendzy
#5 340940_remove_code_style_pl.patch5.26 KBgrendzy
remove-code-style.pl_.patch5.38 KBdamien tournoud

Comments

john morahan’s picture

john morahan commented

+1. Coder has the advantage that PHP programmers (i.e. Drupal developers) can contribute to its development and maintenance. Would be nice if it would chase HEAD though.

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Since this script hasn't really been updated since Feb 2007, I'm going to agree this could be much better maintained in the coder module.

grendzy’s picture

grendzy commented

I tend to agree (Although one downside of relying on coder is it's not available yet for D7).

code-style.pl when run on the current codebase produces a ton of "no mixed case function or variable names" errors, and also hasn't been updated for the new string concat style.

grendzy’s picture

grendzy commented
Status: Needs work » Needs review
StatusFileSize
new 340940_remove_code_style_pl.patch5.26 KB

Now that coder has a release for 7, let's give this another try.

grendzy’s picture

grendzy commented
StatusFileSize
new 340940_remove_code_style_pl.patch5.29 KB

doh. re-rolling from the right directory. ;-)

Status: Needs review » Needs work

The last submitted patch failed testing.

grendzy’s picture

grendzy commented
Status: Needs work » Needs review
StatusFileSize
new empty.patch1 byte

trying to keep pifr happy.

Status: Needs review » Needs work

The last submitted patch failed testing.

grendzy’s picture

grendzy commented
StatusFileSize
new 340940_remove_code_style_pl.patch.txt5.29 KB
new empty.patch338 bytes
grendzy’s picture

grendzy commented
Status: Needs work » Needs review
dries’s picture

dries commented
Status: Needs review » Fixed

Hell, yes. Committed.

damien tournoud’s picture

damien tournoud commented
Status: Fixed » Needs review

I don't believe this got committed.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed now! Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.