This took me so long to figure out.

So I'm working on a new views filter (the boundary filter in the geolocation module here on d.o). That filter has a value form, but currently no operators. This will be important in a moment.

When you open the settings window in the views admin area, you do see label & description, then the value form, and then nothing. All additional options are invisible. They exist in the HTML, but outside of the modal area and can therefor not be interacted with, except using browser tools. See attached image.

The reason for this is, that Claro in claro_form_views_ui_config_item_form_alter() more or less unconditionnally adds 1 open div before the operator form part, and 1 closing div after the value form part, obviously assuming, they would always both be present.

This IMHO already structures additional option form elements in a weired way, when it works as intended, but when there is no operator to begin with, it just breaks. See attached image to get an idea. The --operator part will not be rendered for lack of content.

Comments

ChristianAdamski created an issue. See original summary.

christianadamski’s picture

smustgrave’s picture

Status: Active » Postponed (maintainer needs more info)

Not suer I fully understand the issue? And does the follow up fix the issue?

christianadamski’s picture

Quoting Lendude from the linked issue:

The same happens in Gin. Not 100% sure if this is a core issue or if this should be fixed in the themes or in the filter plugin without the operators, but probably cleanest to do it in core.

I'm not sure either.

Version: 10.2.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

So what was decided should this be re-opened (Moved to active?)

smustgrave’s picture

May an IS update could help decide.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.