Problem/Motivation

This is a child issue of #3376057: [META] Add declare(strict_types=1) to all tests.

Steps to reproduce

Add to phpcs.xml.dist:

  <rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes">
    <properties>
      <property name="spacesCountAroundEqualsSign" value="0" />
    </properties>
    <include-pattern>./tests/Drupal/BuildTests/*</include-pattern>
  </rule>

Run phpcs:

composer phpcs

Proposed resolution

Run phpcbf:

composer phpcbf

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3403711

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mstrelan created an issue. See original summary.

mstrelan’s picture

Status: Active » Needs review

Passed first time, nice

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Thanks for providing easy review steps.

Did exactly as you said added that snippet to the phpcs file

Ran the composer command and got the same 12 files as in the MR.

LGTM!

  • xjm committed 04d38bc9 on 11.x
    Issue #3403711 by mstrelan, smustgrave: Add declare(strict_types=1) to...

  • xjm committed c6feb484 on 10.2.x
    Issue #3403711 by mstrelan, smustgrave: Add declare(strict_types=1) to...
xjm’s picture

Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Helpful scoping, thanks!

Committed to 11.x and 10.2.x, thanks! I did not backport it to 10.1.x as it enables a new phpcs rule in the ruleset.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.