Problem/Motivation
This is a child issue of #3376057: [META] Add declare(strict_types=1) to all tests.
Steps to reproduce
Add to phpcs.xml.dist:
<rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes">
<properties>
<property name="spacesCountAroundEqualsSign" value="0" />
</properties>
<include-pattern>./tests/Drupal/BuildTests/*</include-pattern>
</rule>
Run phpcs:
composer phpcs
Proposed resolution
Run phpcbf:
composer phpcbf
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3403711
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3403711-declare-strict-build
changes, plain diff MR !5518
Comments
Comment #3
mstrelan commentedPassed first time, nice
Comment #4
smustgrave commentedThanks for providing easy review steps.
Did exactly as you said added that snippet to the phpcs file
Ran the composer command and got the same 12 files as in the MR.
LGTM!
Comment #7
xjmHelpful scoping, thanks!
Committed to 11.x and 10.2.x, thanks! I did not backport it to 10.1.x as it enables a new phpcs rule in the ruleset.