Problem/Motivation
In #296693: Restrict access to empty top level administration pages we were testing routes that had the _access_admin_menu_block_page access tag which gets added in \Drupal\system\EventSubscriber\AccessRouteAlterSubscriber::accessAdminMenuBlockPage for routes that use Drupal\system\Controller\SystemController::systemAdminMenuBlockPage
Unfortunately we(meaning me, sorry) used admin/people which I thought used systemAdminMenuBlockPage but looking at the route
entity.user.collection:
path: '/admin/people'
defaults:
_entity_list: 'user'
_title: 'People'
requirements:
_permission: 'administer users'
It does not use that callback.
Steps to reproduce
Proposed resolution
Replace the use of admin/people with admin/reports(or another route that uses systemAdminMenuBlockPage).
Check if we are using any other routes that don't use that controller.
We can leave routes that are using \Drupal\system\Controller\SystemController::overview because that is being addressed in #3381929: Restrict access to empty top level administration pages for overview controller
Remaining tasks
Issue fork drupal-3399537
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
tedbowComment #4
kunal.sachdev commentedLooks good, needs work for some comments in MR.