Problem/Motivation

Body scroll lock is pretty common task in frontend development. And may be required in different components. And not only Dialog.

Now we have library for this:
assets/vendor/tua-body-scroll-lock/tua-bsl.umd.min.js

But it can be used only as part of drupal.dialog library.

In this issue https://www.drupal.org/project/navigation/issues/3392922#comment-15283105
we need it as is. And i also can imagine another cases.

Proposed resolution

Expand bodyscrolllock as separated library

Issue fork drupal-3395797

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

finnsky created an issue. See original summary.

finnsky’s picture

Assigned: finnsky » Unassigned
Status: Active » Needs review
Issue tags: -JavaScript +JavaScript
finnsky’s picture

Issue summary: View changes
Issue tags: -JavaScript +JavaScript
finnsky’s picture

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

The idea of separate library makes sense, especially if it can be used by others.

Only question I have is if it will need a change record for announcing the new library.

nod_’s picture

Status: Reviewed & tested by the community » Postponed

Discussed at drupalcon, the library was a stopgap measure.

An alternative solution with CSS is explored for this in the navigation module, if all works well we'll replicate the same thing in core and potentially drop the library #3392922: Broken mobile toolbar on pages with non-responsive tables.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.