I thought Drupal might change link to "free public providers" in My Account from wiki to official website, which is listing providers in clean fashion and without any redundant information. Here's the patch to change it.

If it's possible, would be great to get it commited to both 6.x and 7.x :) Thanks!

CommentFileSizeAuthor
#17 getopenid-D6.patch2.3 KBalexanderpas
#12 openid-help-2.patch4.52 KBc960657
#2 drupal_openid-prociders_user_friendly_link_try2.diff1.91 KBpatryk
drupal_openid-providers_user_friendly_link.diff1.82 KBpatryk

Comments

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

patryk’s picture

patryk commented
StatusFileSize
new drupal_openid-prociders_user_friendly_link_try2.diff1.91 KB

Patch fixed.

patryk’s picture

patryk commented
Status: Needs work » Needs review
patryk’s picture

patryk commented
Category: feature » task
patryk’s picture

patryk commented

Anyone could comment on this patch, and apply if possible? Thanks.

alexanderpas’s picture

alexanderpas commented
Status: Needs review » Reviewed & tested by the community

most trivial patch of the week...

patryk’s picture

patryk commented

Could someone commit this patch and we can continue to next challenges, please? :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Version: 7.x-dev » 6.x-dev
Issue tags: +Quick fix

Thanks! Committed to HEAD.

Marking back to 6.x, as it looks like it'll apply there too.

patryk’s picture

patryk commented

Thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 6.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Needs work

Interesting that the OpenID links wrap verbatim external links in url(), while the @handbook link does not. I don't think we have a practice of wrapping verbatim external links in url(), and it does not sound logical either. So let's first remove the url() wrappers from the verbatim links in openid_help() and then backport.

patryk’s picture

patryk commented

Do you have any specific recommendation on how should it be done? I might write a patch for that.

c960657’s picture

c960657 commented
Status: Needs work » Needs review
StatusFileSize
new openid-help-2.patch4.52 KB

This patch removes url() around absolute URLs in openid_help().

Status: Needs review » Needs work

The last submitted patch failed testing.

c960657’s picture

c960657 commented
Status: Needs work » Needs review

HEAD broke.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Version: 7.x-dev » 6.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Oh, good catch Gábor. Thanks!

Committed #12 to HEAD. Now this needs to be ported.

alexanderpas’s picture

alexanderpas commented
Assigned: patryk » alexanderpas
Status: Patch (to be ported) » Needs review
StatusFileSize
new getopenid-D6.patch2.3 KB

ported, including removal of url()

patryk’s picture

patryk commented
Status: Needs review » Reviewed & tested by the community

Seems good for me.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed to Drupal 6 too, thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.