Problem/Motivation

The translation system says 'Invalid placeholder' but doesn't say why.

Steps to reproduce

Proposed resolution

Add to the message to say that placeholders must begin with one of the following (....) special characters.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3392200

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented
Status: Active » Postponed (maintainer needs more info)

Can you add the steps to reproduce the issue please?

joachim’s picture

joachim commented
Status: Postponed (maintainer needs more info) » Active

Do:

t("I stupidly used a !exclamation placeholder because I've been around since Drupal 5.", [
  '!exclamation' => 'value',
]);
hdnag’s picture

hdnag commented

yepa is mentoring us (me & jeremy_p) with this issue

jeremy_p made their first commit to this issue’s fork.

jeremy_p opened merge request !5065

joachim’s picture

joachim commented
Status: Active » Needs work

MR looks good, but the test that's failing needs to be updated so it's looking for the new version of the error message.

jeremy_p’s picture

jeremy_p commented

Sorry for the failing test, i've made a new commit to fix it.

joachim’s picture

joachim commented
Status: Needs work » Reviewed & tested by the community

Looks good!

Remember to set an issue to Needs Review when you think it's ready.

sleitner’s picture

sleitner commented
Component: transliteration system » render system

lauriii made their first commit to this issue’s fork.

  • lauriii committed 8abb2835 on 11.x 
    Issue #3392200 by jeremy_p, joachim, hdnag, yepa: Invalid placeholder...

  • lauriii committed e3e71a94 on 10.2.x 
    Issue #3392200 by jeremy_p, joachim, hdnag, yepa: Invalid placeholder...

lauriii closed merge request !5065

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 8abb283 and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.