Problem/Motivation

I noticed two errors in the use of the cspell directives.

1) In ckeditor5 *.js files cspell:words is used instead of cspell:ignore
2) in d7_block.yml there is a space after cspell in the ignore line.

Steps to reproduce

Proposed resolution

Fix both usages

Remaining tasks

Review

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3390969-6-after.png64.08 KBshyam_bhatt
#6 3390969-6-before.png270.02 KBshyam_bhatt
#5 3390969-5.patch24.88 KBquietone
#5 interdiff-2-5.txt3.66 KBquietone
#4 Screenshot 2023-10-02 at 9.36.24 AM.png47.2 KBsmustgrave
#2 3390969-2.patch19.71 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
StatusFileSize
new 3390969-2.patch19.71 KB

sed is such a useful tool.

Here is the patch.

quietone’s picture

quietone commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot 2023-10-02 at 9.36.24 AM.png47.2 KB

Searching for cspell:words found few more instances

instances

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-5.txt3.66 KB
new 3390969-5.patch24.88 KB

Don't know how I missed those, thanks.

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3390969-6-before.png270.02 KB
new 3390969-6-after.png64.08 KB

@quietone I have checked the #5 patch working fine with the 11.x branch.

In ckeditor5 *.js files cspell:words replaced with cspell:ignore and a space after cspell was removed from d7_block.yml file.

Before:
2023-10-03/3390969-6-before.png

After:
2023-10-03/3390969-6-after.png

Moving to + RTBC

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed c09c0e59d4 to 11.x and 73533d423d to 10.2.x and 500421a5ff to 10.1.x. Thanks!

  • longwave committed 500421a5 on 10.1.x 
    Issue #3390969 by quietone, Shyam_Bhatt, smustgrave: Cleanup cspell...

  • longwave committed 73533d42 on 10.2.x 
    Issue #3390969 by quietone, Shyam_Bhatt, smustgrave: Cleanup cspell...

  • longwave committed c09c0e59 on 11.x 
    Issue #3390969 by quietone, Shyam_Bhatt, smustgrave: Cleanup cspell...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.