Problem/Motivation
It can be tricky, and annoying, to keep the composer.json files following a consistent format.
Proposed resolution
Use ergebnis/composer-normalize to normalize the composer files.
Remaining tasks
Agree on the change.
Provide a patch that includes normalized composer.json files.
User interface changes
n/a
API changes
n/a
Data model changes
n/a
Release notes snippet
TBD
| Comment | File | Size | Author |
|---|
Issue fork drupal-3390229
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
damienmckennaThis was suggested to me in the Schema.org Metatag issue queue by Rajeshreeputra (#3313582: Normalize composer.json using ergebnis/composer-normalize), I thought it would be worth to include in Drupal core.
Comment #3
elberI will work on it
Comment #5
elberHi Normalized composer.json following this doc instructions
Here are the steps:
composer require --dev ergebnis/composer-normalizecomposer normalize --diffAs a result I had this output
Successfully normalized ./composer.json.and a diff information(see the attached bellow)Comment #6
elberComment #7
damienmckennaThe patch was built incorrectly - the changes should have been applied directly using "composer normalize", and then a patch built using "git diff".
The merge request was built correctly.
There are also a lot of other composer.json files strewn across the codebase, all of them need to be updated too.
Comment #8
elberOk I am sorry @DamienMcKenna I put the diff file to become the review easier, diff is not to be applied. Once I'm sorry I should clarify it.
I wiill keep working on the others composer.json files.