Problem/Motivation

in[#2936995] we are adding revision UI for taxonomy term, to keep things consistent and for better debugging we should add setReason() calls similar to TermAccessControlHandler.php in \Drupal\block_content\BlockContentAccessControlHandler::checkAccess.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

yash.rode created an issue. See original summary.

yash.rode’s picture

yash.rode commented
Title: Add setReason() calls at the end of revision related cases of BlockContentAccessControlHandler::checkAccess for debugging consistency » Add setReason() calls for debugging and consistency
Status: Active » Postponed
Related issues: +#2936995: Add taxonomy term revision UI

Once [#2936995]is in, we should address this.

yash.rode’s picture

yash.rode commented
Issue summary: View changes
acbramley’s picture

acbramley commented
Status: Postponed » Postponed (maintainer needs more info)

The taxonomy issue is in, however BlockContentAccessControlHandler uses a match and returns AccessResult::allowedIfHasPermission which already sets a reason. I'm not seeing much to do here anymore?

acbramley’s picture

acbramley commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Closing as per #4