Problem/Motivation

With a dark color scheme, the icon is reasonably visible, but not with a light scheme. We can leverage system colors to provide a solution that works regardless of scheme.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 yay-light.png109.3 KBbnjmnm
#3 yay-dark.png85.61 KBbnjmnm
#3 no-good-forced-colors.png112.1 KBbnjmnm

Issue fork drupal-3377207

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

bnjmnm opened merge request !4482

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Assigned: bnjmnm » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new no-good-forced-colors.png112.1 KB
new yay-dark.png85.61 KB
new yay-light.png109.3 KB

Solution in MR. Forced colors background SVG uses buttonText system color as BG color, so it is visible regardless of the forced color scheme.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Verified the issue using a dark mode extension on chrome (allows to select light mode also)
MR seems to resolve the issue.

  • lauriii committed 9947041b on 11.x 
    Issue #3377207 by bnjmnm, smustgrave: Dialog close icon not reliably...

  • lauriii committed 35d5e6f9 on 10.1.x 
    Issue #3377207 by bnjmnm, smustgrave: Dialog close icon not reliably...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 9947041 and pushed to 11.x. Also cherry-picked to 10.1.x. Thanks!

lauriii closed merge request !4482

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.