Problem/Motivation

Despite #2921133: Remove "Please" from the codebase there is still 'Please' in the code base. This is because I forgot to run yarn spellcheck:core before making the last patch. This error could be prevented by #3212579: Spell check all files if dictionary.txt changes

Proposed resolution

run yarn spellcheck:core and fix any more instances of 'please'.

Remaining tasks

Patch
Review
Commit

User interface changes

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#3 3376431-2.patch2.58 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Parent issue: #2921133: Remove "Please" from the codebase »
quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 3376431-2.patch2.58 KB

I did update the dictionary in #2921133: Remove "Please" from the codebase but the patch did not include them. Sigh.

So, this patch was made after running yarn spellcheck:core to find the lines to fix. Then again to make sure that all instances were fixed. And finally, rebuild the dictionary. yarn spellcheck:make-drupal-dict.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Reviewed & tested by the community

Checked out core, ran spelcheck, found the files in this patch having errors, applies patch, ran again, no errors anymore. Seems as fixed as it should be.

  • catch committed 7939d080 on 11.x 
    Issue #3376431 by quietone, bbrala: Spellcheck core after removal of "...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 7939d08 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.