Splitting off from #107051: Same user listed multiple times in who's online block so it can move down to D6 and 5.

CommentFileSizeAuthor
#6 336596-whos-online-test-D7.patch3.3 KBdave reid
#5 336596-whos-online-test-D7.patch3.38 KBdave reid
#4 336596-whos-online-test-D7.patch2.88 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Assigned: Unassigned » dave reid

Assigning myself since I had fun working on the patch for that issue. Should have a test done with a day.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Subscribe! :)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Would calling user_block() and testing it's output be the best way to test this?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 336596-whos-online-test-D7.patch2.88 KB

Initial test for review. It's testing the who's online block with no user sessions, a duplicated user session, anonymous user count.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 336596-whos-online-test-D7.patch3.38 KB

Revised patch that tests to make sure the users are ordered correctly.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 336596-whos-online-test-D7.patch3.3 KB

Small revisions in docs and strings.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me and ran the tests locally, nice touch checking for ordering too.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Excellent! :)

Committed to HEAD, thanks for the follow-through!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.