Problem/Motivation
In #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections() @nod_ introduced a "fix" for problems with the correct opening of an off-canvas dialog which potentially could fix all JS random test failures for tests using the drupal.dialog.off_canvas somehow.
The basic test is:
- Unskip
\Drupal\Tests\layout_builder\FunctionalJavascript\MoveBlockFormTest. - Run _only_ now unskipped
\Drupal\Tests\layout_builder\FunctionalJavascript\MoveBlockFormTesta lot of times (usually we go for 1500x) as-is. - Run _only_ now unskipped
\Drupal\Tests\layout_builder\FunctionalJavascript\MoveBlockFormTesta lot of times (usually we go for 1500x) _without_ the changes in #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections(). - If 2., passes and 3. doesn't, we can safely turn the test back on again.
Per @xjm in #3353085-4: [meta] Determine impact of [#3350972] fix in off-canvas.js on currently disabled FunctionalJavascript tests we now need to go for a 5000-8000 times run for both patches.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | MoveBlockFormTest-no_#3350972-1500x-should_fail.patch | 3.52 KB | spokje |
| #3 | MoveBlockFormTest-1500x.patch | 3.03 KB | spokje |
Comments
Comment #2
spokjeComment #3
spokjeComment #4
spokjeOk, so there are definitely other issues with this test.