Problem/Motivation

In #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections() @nod_ introduced a "fix" for problems with the correct opening of an off-canvas dialog which potentially could fix all JS random test failures for tests using the drupal.dialog.off_canvas somehow.

The basic test is:

  1. Unskip all $this->markTestSkipped(); in \Drupal\Tests\layout_builder\FunctionalJavascript\ContextualLinksTest.
  2. Run _only_ now unskipped \Drupal\Tests\layout_builder\FunctionalJavascript\ContextualLinksTest a lot of times (usually we go for 1500x) as-is.
  3. Run _only_ now unskipped \Drupal\Tests\layout_builder\FunctionalJavascript\ContextualLinksTest a lot of times (usually we go for 1500x) _without_ the changes in #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections().
  4. If 2., passes and 3. doesn't, we can safely turn the test back on again.

Per @xjm in #3353085-4: [meta] Determine impact of [#3350972] fix in off-canvas.js on currently disabled FunctionalJavascript tests we now need to go for a 5000-8000 times run for both patches.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3353092-6.patch1.08 KBspokje
#5 ContextualLinksTest-no_#3350972-1500x-should_fail.patch3.34 KBspokje
#5 ContextualLinksTest-1500x.patch2.85 KBspokje
#3 3353092-3.patch670 bytesspokje
#2 ContextualLinksTest_testContextualLinks-no_#3350972-1500x-should_fail.patch2.92 KBspokje
#2 ContextualLinksTest_testContextualLinks-1500x.patch3.36 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
StatusFileSize
new ContextualLinksTest_testContextualLinks-1500x.patch3.36 KB
new ContextualLinksTest_testContextualLinks-no_#3350972-1500x-should_fail.patch2.92 KB
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3353092-3.patch670 bytes
spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new ContextualLinksTest-1500x.patch2.85 KB
new ContextualLinksTest-no_#3350972-1500x-should_fail.patch3.34 KB

Right...

So we have a skipped assertion in a skipped test...

Let's see what happens if we un-skip them at the same time.

spokje’s picture

spokje
Primary language Dutch
commented
Title: [random test failure] Try to un-skip and fix ContextualLinksTest::testContextualLinks() in context of [#3353085] » [random test failure] Try to un-skip and fix ContextualLinksTest in context of [#3353085]
Issue summary: View changes
StatusFileSize
new 3353092-6.patch1.08 KB

The last submitted patch, 5: ContextualLinksTest-no_#3350972-1500x-should_fail.patch, failed testing. View results

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Condition in the issue summary appears to have been met.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

The last submitted patch, 2: ContextualLinksTest_testContextualLinks-no_#3350972-1500x-should_fail.patch, failed testing. View results

The last submitted patch, 2: ContextualLinksTest_testContextualLinks-no_#3350972-1500x-should_fail.patch, failed testing. View results

The last submitted patch, 2: ContextualLinksTest_testContextualLinks-no_#3350972-1500x-should_fail.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje
Status: Reviewed & tested by the community » Needs work
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Needs work » Reviewed & tested by the community

Both should_fail and non_fail patch run 5 times. That's 7500 individual tests per patch.

Back to RTBC.

xjm’s picture

xjm
she/her
Primary language English
commented

Added additional test jobs and waiting on those for commit.

xjm’s picture

xjm
she/her
Primary language English
commented

Fixing attribution.

  • catch committed 3e7279b0 on 10.1.x 
    Issue #3353092 by Spokje: [random test failure] Try to un-skip and fix...

  • catch committed 2ac23c8f on 10.0.x 
    Issue #3353092 by Spokje: [random test failure] Try to un-skip and fix...

  • catch committed c4ed1535 on 9.5.x 
    Issue #3353092 by Spokje: [random test failure] Try to un-skip and fix...
catch’s picture

catch
he/him
Primary language English
commented
Version: 10.1.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x, thanks! Since this is the last of the current round to be re-enabled I've also cherry-picked back to 10.0.x and 9.5.x. Next to cherry-pick back the other patches.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.