Problem/Motivation

Follow-up for #2915772: Deprecate non_lazy_route_enhancer service tag in favor of route_enhancer, same for non_lazy_route_filter and route_filter

Also need to remove outdated todo

Proposed resolution

remove deprecated methods and tests

Remaining tasks

patch/review/commit

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3347710-2.patch4.51 KBandypost

Issue fork drupal-3347710

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3347710-2.patch4.51 KB
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Postponed

This looks good, but marking postponed until 11.x is open.

Kaushik1216’s picture

Kaushik1216 commented
Title: Remove deprected non_lazy_route_enhancer and non_lazy_route_filter » Remove deprecated non_lazy_route_enhancer and non_lazy_route_filter
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Remove deprecated non_lazy_route_enhancer and non_lazy_route_filter » [11.x] Remove deprecated non_lazy_route_enhancer and non_lazy_route_filter
Version: 11.0.x-dev » 11.x-dev
Issue tags: +Major version only

Updating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...

andypost opened merge request !6852

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Postponed » Needs review

as 11.x open

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Parent issue: #2915772: Deprecate non_lazy_route_enhancer service tag in favor of route_enhancer, same for non_lazy_route_filter and route_filter » #3423886: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 11 branch
Related issues: +#2915772: Deprecate non_lazy_route_enhancer service tag in favor of route_enhancer, same for non_lazy_route_filter and route_filter

Seems to have a check failure.

Changed the parent to the Meta for tracking the removal of deprecated stuff for 11

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

fixed CS

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Removal looks good to me.

smustgrave’s picture

smustgrave commented
Parent issue: #3423886: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 11 branch » #3295574: [meta] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 11 branch

Seems we had 2 meta consolidating.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed 7454e5d and pushed to 11.x. Thanks!

  • longwave committed 7454e5df on 11.x 
    Issue #3347710 by andypost: [11.x] Remove deprecated...

longwave closed merge request !6852

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented
Version: 11.x-dev » 11.0.x-dev

Update version to the branch this applies to.